[
https://issues.apache.org/jira/browse/FLINK-2551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15092774#comment-15092774
]
ASF GitHub Bot commented on FLINK-2551:
---------------------------------------
GitHub user ndimiduk opened a pull request:
https://github.com/apache/flink/pull/1497
FLINK-2551 Fix Several Bugs in Input/Output Formats
This is a patch that fixes the last issue listed on the ticket description,
"The Streaming API does not call setInputType if a format implements
InputTypeConfigurable". I don't know why my application code exercises this
code path while none of the uses of `DataStream.write` in the flink test code
do. This patch also applies cleanly on the `release-0.10` branch.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ndimiduk/flink
2551-FileSinkFunction-delegate-InputTypeConfigurable
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1497.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1497
----
commit 2d5c1bfa3d1525f6d1f8d46472e92a44cf7df83c
Author: Nick Dimiduk <[email protected]>
Date: 2016-01-11T22:02:28Z
FLINK-2551 Fix Several Bugs in Input/Output Formats
----
> Fix Several Bugs in Input/Output Formats
> ----------------------------------------
>
> Key: FLINK-2551
> URL: https://issues.apache.org/jira/browse/FLINK-2551
> Project: Flink
> Issue Type: Bug
> Affects Versions: 0.9
> Reporter: Aljoscha Krettek
> Assignee: Aljoscha Krettek
>
> This is a collection of several things that are wrong (or possibly
> problematic) in the handling of Input/Output formats.
> The things I have so far:
> - TypeSerializerInputFormat was changed to take a TypeInformation instead of
> a TypeSerialzer. The javadoc is not updated, however
> - This lead to another bug: When the serializer is created from the
> TypeInformation it is not given the correct ExecutionConfig from the
> ExecutionEnvironment and thus custom serializers don't work. (This one, I
> broke)
> - In BinaryOutputFormat some fields are not declared transient even though
> they should be
> - The Streaming API does not call {{setInputType}} if a format implements
> {{InputTypeConfigurable}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
