wuchong commented on a change in pull request #11925:
URL: https://github.com/apache/flink/pull/11925#discussion_r416542244
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/codegen/CodeGenUtils.scala
##########
@@ -132,6 +136,15 @@ object CodeGenUtils {
* Returns a term for representing the given class in Java code.
*/
def typeTerm(clazz: Class[_]): String = {
+ if (clazz == classOf[StringData]) {
Review comment:
There are too many calls on the `BinaryStringData` in code generation
now, if we use StringData in code generation, we have to refactor a lot of
codes. And we don't benefit much from this effort. I created FLINK-17437 to
track this, we can refactor this in the future.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
