lirui-apache commented on pull request #11935: URL: https://github.com/apache/flink/pull/11935#issuecomment-620963790
Hey @JingsongLi > Migrate DDL by hive client to DDL by flink tEnv in tests. I have plans for this but the parser doesn't support DML yet. If we migrate now, we'll have to switch dialects back and forth in the tests which undermines code readability. I'll have a separate PR to do the migration when the parser supports all the common DDL and DML. > Can you add some cases to create hive table from flink DDL? Like we can support "connector=hive". This is actually out of the scope of this PR and even out of the scope of FLIP-123. We never promised users they can create hive table with Flink DDLs in previous versions, so I don't think we need test cases to cover that right now. But of course, we can revisit this use case if there're concrete requirements in the future. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
