rkhachatryan commented on a change in pull request #11899:
URL: https://github.com/apache/flink/pull/11899#discussion_r417358710
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGenerator.java
##########
@@ -969,15 +969,17 @@ private void configureCheckpointing() {
triggerVertices,
ackVertices,
commitVertices,
- new CheckpointCoordinatorConfiguration(
- interval,
- cfg.getCheckpointTimeout(),
- cfg.getMinPauseBetweenCheckpoints(),
- cfg.getMaxConcurrentCheckpoints(),
- retentionAfterTermination,
- getCheckpointingMode(cfg) ==
CheckpointingMode.EXACTLY_ONCE,
- cfg.isPreferCheckpointForRecovery(),
- cfg.getTolerableCheckpointFailureNumber()),
+ CheckpointCoordinatorConfiguration.builder()
+ .setCheckpointInterval(interval)
+
.setCheckpointTimeout(cfg.getCheckpointTimeout())
+
.setMinPauseBetweenCheckpoints(cfg.getMinPauseBetweenCheckpoints())
+
.setMaxConcurrentCheckpoints(cfg.getMaxConcurrentCheckpoints())
+
.setCheckpointRetentionPolicy(retentionAfterTermination)
+ .setExactlyOnce(getCheckpointingMode(cfg) ==
CheckpointingMode.EXACTLY_ONCE)
+
.setPreferCheckpointForRecovery(cfg.isPreferCheckpointForRecovery())
+
.setTolerableCheckpointFailureNumber(cfg.getTolerableCheckpointFailureNumber())
+
.setUnalignedCheckpointsEnabled(cfg.isUnalignedCheckpointsEnabled())
Review comment:
I don't see any problems here, at least on `CheckpointCoordinator` side.
Do you have something specific in mind?
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointProperties.java
##########
@@ -248,6 +248,15 @@ public String toString() {
false,
false);
+ private static final CheckpointProperties SYNC_SAVEPOINT_NOT_FORCED =
new CheckpointProperties(
+ false,
Review comment:
This is covered by `PendingCheckpointTest.testCanBeSubsumed`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
