twalthr commented on a change in pull request #11959: URL: https://github.com/apache/flink/pull/11959#discussion_r419893421
########## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/connector/format/Format.java ########## @@ -0,0 +1,57 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.connector.format; + +import org.apache.flink.annotation.Internal; +import org.apache.flink.api.common.serialization.DeserializationSchema; +import org.apache.flink.table.connector.ChangelogMode; +import org.apache.flink.table.connector.sink.DynamicTableSink; +import org.apache.flink.table.connector.source.ScanTableSource; +import org.apache.flink.table.factories.DynamicTableFactory; + +/** + * Base interface for connector formats. + * + * <p>Depending on the kind of external system, a connector might support different encodings for + * reading and writing rows. This interface is an intermediate representation before constructing actual + * runtime implementation. + * + * <p>Formats can be distinguished along two dimensions: + * <ul> + * <li>Context in which the format is applied (e.g. {@link ScanTableSource} or {@link DynamicTableSink}). + * <li>Runtime implementation interface that is required (e.g. {@link DeserializationSchema} or + * some bulk interface).</li> + * </ul> + * + * <p>A {@link DynamicTableFactory} can search for a format that it is accepted by the connector. + * + * @see ScanFormat + * @see SinkFormat + * + * @param <I> underlying runtime interface + */ +@Internal +public interface Format<I> { Review comment: good point, it was required in an earlier version but not anymore ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
