[ 
https://issues.apache.org/jira/browse/FLINK-16733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17099661#comment-17099661
 ] 

Kostas Kloudas commented on FLINK-16733:
----------------------------------------

Sorry, I just saw the last two comments.  I was not aware of them. I already 
opened a small refactoring PR for 
https://issues.apache.org/jira/browse/FLINK-17515, but now I see that you are 
already discussing about refactoring the whole {{YarnClusterDescriptor}} (which 
I agree that it must be done).

If you already have code and my PR messes up your work, I can close it. There 
is no problem. In fact my PR was just made as a first step towards adding 
functionality that allows to use already uploaded (on HDFS) artifacts (jars, 
etc) when submitting an application to YARN (similar to 
https://issues.apache.org/jira/browse/FLINK-17472).

Let me know what you think [~xintongsong], [~tison], [~felixzheng] and [~rongr]

> Refactor YarnClusterDescriptor
> ------------------------------
>
>                 Key: FLINK-16733
>                 URL: https://issues.apache.org/jira/browse/FLINK-16733
>             Project: Flink
>          Issue Type: Improvement
>          Components: Deployment / YARN
>            Reporter: Xintong Song
>            Assignee: Xintong Song
>            Priority: Minor
>
> Currently, YarnClusterDescriptor is not in a good shape. It has 1600+ lines 
> of codes, of which the method {{startAppMaster}} alone has 400+ codes, 
> leading to poor maintainability.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to