[GitHub] [flink] tillrohrmann commented on a change in pull request #11963: [FLINK-16408] Bind user code class loader to lifetime of Job on TaskExecutor

[GitBox]

tillrohrmann commented on a change in pull request #11963:
URL: https://github.com/apache/flink/pull/11963#discussion_r420652747



##########
File path: 
flink-runtime/src/test/java/org/apache/flink/runtime/execution/librarycache/BlobLibraryCacheRecoveryITCase.java
##########
@@ -103,8 +107,8 @@ public void testRecoveryRegisterAndDownload() throws 
Exception {
                        cache = new PermanentBlobCache(config, 
blobStoreService, serverAddress[0]);
 
                        // Register uploaded libraries
-                       ExecutionAttemptID executionId = new 
ExecutionAttemptID();
-                       libServer[0].registerTask(jobId, executionId, keys, 
Collections.<URL>emptyList());
+                       final LibraryCacheManager.ClassLoaderLease 
classLoaderLease = libServer[0].registerClassLoaderLease(jobId);
+                       classLoaderLease.getOrResolveClassLoader(keys, 
Collections.emptyList());

Review comment:
       Yes exactly.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org