WeiZhong94 commented on a change in pull request #11960: URL: https://github.com/apache/flink/pull/11960#discussion_r421204158
########## File path: flink-python/pyflink/table/tests/test_pandas_udf.py ########## @@ -142,7 +142,7 @@ def time_func(time_param): 'time_param of wrong type %s !' % type(time_param[0]) return time_param - timestamp_value = datetime.datetime(1970, 1, 1, 0, 0, 0, 123000) + timestamp_value = datetime.datetime(1970, 1, 2, 0, 0, 0, 123000) Review comment: In windows the `time.mktime()` does not support negative UTC timestamp value. So we need to ensure the datetime object won't produce a negative UTC timestamp value. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org