pnowojski commented on a change in pull request #11687:
URL: https://github.com/apache/flink/pull/11687#discussion_r422086939
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/reader/AbstractRecordReader.java
##########
@@ -63,6 +63,8 @@ protected AbstractRecordReader(InputGate inputGate, String[]
tmpDirectories) {
}
protected boolean getNextRecord(T target) throws IOException,
InterruptedException {
+ inputGate.requestPartitions();
Review comment:
nit: maybe add a small comment why is done like so here?
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/SingleInputGateFactory.java
##########
@@ -190,6 +190,7 @@ private InputChannel createInputChannel(
partitionRequestMaxBackoff,
metrics);
},
+ // TODO: can we sometimes call createKnownInputChannel?
Review comment:
nit: remove comment
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
