Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/967#issuecomment-171970520
I think the SSP code look in good shape.
Concerning the parameter server code, I think we should not add this this
to Flink's repository, but it should be hosted in an external repository. We
have to be a bit cautious at this point to not overload the Flink code base.
I would very much like to get a culture starting where people also build
and offer libraries and tools for Flink in their own (3rd party) repositories.
It has the advantage that teh main authors are in control of the code. Bugfixes
can be applied fast, release can be made frequently (no Apache processes). The
core repository stays slim, which makes it easier to maintain.
- One possible place for the parameter server code would be a repository
under https://github.com/project-flink . We can create one and grant you access
rights.
- We can link the parameter server code under
http://flink.apache.org/community.html#third-party-packages
What we would need to do is split up this code into the SSP part (gets into
the Flink code) and the Parameter Server part. The SSP part can probably be
kept independent from any use with parameter servers (even though the most
common and meaningful application is in conjunction with a parameter server).
Any thoughts on this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
