[
https://issues.apache.org/jira/browse/FLINK-3243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15102149#comment-15102149
]
ASF GitHub Bot commented on FLINK-3243:
---------------------------------------
GitHub user aljoscha opened a pull request:
https://github.com/apache/flink/pull/1513
[FLINK-3243] Fix Interplay of TimeCharacteristic and Time Windows
This adds dedicated WindowAssigners for processing time and event time.
timeWindow() and timeWindowAll() respect the TimeCharacteristic set
on the StreamExecutionEnvironment.
This will make the easy stuff easy, i.e. using time windows and quickly
switching the time characteristic. Users will then have the flexibility
to mix different kinds of window assigners in their job.
This also expands the translation tests to verify that the correct
window operators are instantiated.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aljoscha/flink time-characteristic-fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1513.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1513
----
commit 7df1f2265beec91584373ac66f8cdc05fc46e6f8
Author: Aljoscha Krettek <[email protected]>
Date: 2016-01-15T15:37:16Z
[hotfix] Fix enum names of TimeCharacteristic
Before, they where CamelCase while standard Java style suggests that
they should be ALL_UPPERCASE.
commit f5e0a9d86cdf8f292ca0c4a45d34abb98f3ee68b
Author: Aljoscha Krettek <[email protected]>
Date: 2016-01-15T16:05:12Z
[FLINK-3243] Fix Interplay of TimeCharacteristic and Time Windows
This adds dedicated WindowAssigners for processing time and event time.
timeWindow() and timeWindowAll() respect the TimeCharacteristic set
on the StreamExecutionEnvironment.
This will make the easy stuff easy, i.e. using time windows and quickly
switching the time characteristic. Users will then have the flexibility
to mix different kinds of window assigners in their job.
This also expands the translation tests to verify that the correct
window operators are instantiated.
----
> Fix Interplay of TimeCharacteristic and Time Windows
> ----------------------------------------------------
>
> Key: FLINK-3243
> URL: https://issues.apache.org/jira/browse/FLINK-3243
> Project: Flink
> Issue Type: Bug
> Components: Streaming
> Affects Versions: 1.0.0
> Reporter: Aljoscha Krettek
> Assignee: Aljoscha Krettek
> Priority: Blocker
>
> As per the discussion on the Dev ML:
> http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-Time-Behavior-in-Streaming-Jobs-Event-time-processing-time-td9616.html.
> The discussion seems to have converged on option 2):
> - Add dedicated WindowAssigners for processing time and event time
> - {{timeWindow()}} and {{timeWindowAll()}} respect the set
> {{TimeCharacteristic}}.
> This will make the easy stuff easy, i.e. using time windows and quickly
> switching the time characteristic. Users will then have the flexibility to
> mix different kinds of window assigners in their job.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
