[ 
https://issues.apache.org/jira/browse/FLINK-17710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17107846#comment-17107846
 ] 

Hequn Cheng edited comment on FLINK-17710 at 5/15/20, 2:05 AM:
---------------------------------------------------------------

CC [~nicholasjiang]. I think we should not assertFalse for the terminal_state, 
the job may still running or otherwise.
{code:java}
        self.assertFalse(job_status.is_globally_terminal_state())
        self.assertFalse(job_status.is_terminal_state())
{code}
We can assertIsNotNone here. I Will create a hotfix to correct this. OrĀ 
[~nicholasjiang] do you want to fix this?


was (Author: hequn8128):
CC [~nicholasjiang]. I think we should not assertFalse for the terminal_state, 
the job may still running or otherwise. 
{code}
        self.assertFalse(job_status.is_globally_terminal_state())
        self.assertFalse(job_status.is_terminal_state())
{code}
We can assertIsNotNone here. I Will create a hotfix to correct this. 

> StreamSqlTests.test_execute_sql test is not stable
> --------------------------------------------------
>
>                 Key: FLINK-17710
>                 URL: https://issues.apache.org/jira/browse/FLINK-17710
>             Project: Flink
>          Issue Type: Bug
>          Components: API / Python
>            Reporter: Hequn Cheng
>            Priority: Major
>
> Failure log:
> https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_apis/build/builds/1311/logs/144



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to