curcur commented on a change in pull request #11725:
URL: https://github.com/apache/flink/pull/11725#discussion_r425552869
##########
File path:
flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducer.java
##########
@@ -210,7 +210,7 @@
/**
* The name of the default topic this producer is writing data to.
*/
- private final String defaultTopicId;
+ protected final String defaultTopicId;
Review comment:
It was fine to use "package-private" previously, but I have moved all
the KafkaShuffle related classes to a separate package. So, it is not
sufficient any more.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]