wangyang0918 commented on a change in pull request #11010:
URL: https://github.com/apache/flink/pull/11010#discussion_r425563975



##########
File path: 
flink-kubernetes/src/main/java/org/apache/flink/kubernetes/KubernetesResourceManager.java
##########
@@ -91,6 +93,8 @@
        /** The number of pods requested, but not yet granted. */
        private int numPendingPodRequests = 0;
 
+       private KubernetesWatch podsWatch;

Review comment:
       Every open source project has its own lifecycle. I could see the 
official K8s java client is becoming better with fast evolving. Maybe we will 
replace the actual implementation in the future. It is just personal thought. 
Certainly you could have your own and we do not need to reach a consensus here.
   
   Whatever, introducing the wrapper class does not bring too much burden to 
our current implementation. So i will try to keep them. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to