azagrebin commented on a change in pull request #12131:
URL: https://github.com/apache/flink/pull/12131#discussion_r425772745



##########
File path: docs/ops/deployment/kubernetes.md
##########
@@ -274,44 +341,121 @@ spec:
             path: flink-conf.yaml
           - key: log4j.properties
             path: log4j.properties
-
 {% endhighlight %}
 
-`jobmanager-service.yaml`
+### Job cluster resource definitions
+
+`jobmanager-job.yaml`
 {% highlight yaml %}
-apiVersion: v1
-kind: Service
+apiVersion: batch/v1

Review comment:
       I am fully familiar with versioning of Kubernetes components but it 
matters. The versions correspond to the current examples on Kubernetes docs.

##########
File path: docs/ops/deployment/kubernetes.md
##########
@@ -274,44 +341,121 @@ spec:
             path: flink-conf.yaml
           - key: log4j.properties
             path: log4j.properties
-
 {% endhighlight %}
 
-`jobmanager-service.yaml`
+### Job cluster resource definitions
+
+`jobmanager-job.yaml`
 {% highlight yaml %}
-apiVersion: v1
-kind: Service
+apiVersion: batch/v1

Review comment:
       I am fully familiar with versioning of Kubernetes components but it 
matters. The versions correspond to the current examples in Kubernetes docs.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to