AHeise commented on a change in pull request #11814:
URL: https://github.com/apache/flink/pull/11814#discussion_r425941569
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/channel/ChannelStateWriterImpl.java
##########
@@ -91,6 +91,7 @@ public ChannelStateWriterImpl(CheckpointStorageWorkerView
streamFactoryResolver)
@Override
public void start(long checkpointId, CheckpointOptions
checkpointOptions) {
+ results.keySet().forEach(oldCheckpointId ->
abort(oldCheckpointId, new Exception("Starting new checkpoint " +
checkpointId)));
Review comment:
You are right that it's probably not needed. However, it's an
inexpensive check that verifies the highlighted line.
I'd keep the check for now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
