[
https://issues.apache.org/jira/browse/FLINK-1666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15107008#comment-15107008
]
ASF GitHub Bot commented on FLINK-1666:
---------------------------------------
GitHub user fhueske opened a pull request:
https://github.com/apache/flink/pull/1520
[FLINK-1666] [FLINK-1903] [FLINK-3233] Refactor expression keys.
- Unify usage of expression keys: FLINK-1666
- Unify supported key expressions (incl. support for partitioning on atomic
types: FLINK-3233)
- Remove removal of duplicate keys: FLINK-1903
- Unify checks for sort keys
- Add more tests for SelectorFunctionKeys and ExpressionKeys
- Fixed most compiler warnings in touched files
Sorry for merging several issues in this PR.
FLINK-1903 and FLINK-3233 are fixed as a side effect of FLINK-1666.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/fhueske/flink expressionKeys
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1520.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1520
----
commit da515e70746c147d1b95b62318767616e7075051
Author: Fabian Hueske <[email protected]>
Date: 2016-01-14T21:48:43Z
[FLINK-1666] [FLINK-1903] [FLINK-3233] Refactor expression keys.
- Unify usage of expression keys: FLINK-1666
- Unify supported key expressions (incl. support for partitioning on atomic
types: FLINK-3233)
- Remove removal of duplicate keys: FLINK-1903
- Unify checks for sort keys
- Add more tests for SelectorFunctionKeys and ExpressionKeys
----
> Clean-up Field Expression Code
> ------------------------------
>
> Key: FLINK-1666
> URL: https://issues.apache.org/jira/browse/FLINK-1666
> Project: Flink
> Issue Type: Improvement
> Components: DataSet API
> Affects Versions: 0.9
> Reporter: Fabian Hueske
> Assignee: Fabian Hueske
>
> Field expressions are supported at various places in the user facing APIs.
> However, not every feature allows exactly the same syntax. Also, code for
> analyzing field expressions is scattered around several places.
> Right now, most of the field expression handling is done in the
> {{PojoTypeInfo}}, {{CaseClassTypeInfo}}, and {{ExpressionKeys}} classes.
> Corner cases are inconsistently handled at several other places.
> We should clean this up and add one utility class that defines the syntax of
> field expressions.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
