[GitHub] [flink] JingsongLi commented on a change in pull request #12206: [FLINK-14255][hive] Integrate hive to streaming file sink with parquet and orc

[GitBox]

JingsongLi commented on a change in pull request #12206:
URL: https://github.com/apache/flink/pull/12206#discussion_r426348785



##########
File path: 
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/client/HiveShim.java
##########
@@ -205,4 +208,10 @@ SimpleGenericUDAFParameterInfo 
createUDAFParameterInfo(ObjectInspector[] params,
         */
        void createTableWithConstraints(IMetaStoreClient client, Table table, 
Configuration conf,
                        UniqueConstraint pk, List<Byte> pkTraits, List<String> 
notNullCols, List<Byte> nnTraits);
+
+       /**
+        * Create orc {@link BulkWriter.Factory} for different hive versions.
+        */
+       BulkWriter.Factory<RowData> createOrcBulkWriterFactory(

Review comment:
       I think this is hive shim, because orc factory is related to hive 
version.
   If not this, will be a ugly `if else`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org