docete opened a new pull request #12218:
URL: https://github.com/apache/flink/pull/12218


   …nvironment.connect().createTemporaryTable()
   
   
   ## What is the purpose of the change
   
   Since FLINK-14490 , proctime()/rowtime() doesn't work for 
TableEnvironment.connect().createTemporaryTable(), The root cause is described 
on jira ticket.
   
   ## Brief change log
   
   - instantiate the TableSource in CatalogSchemaTable and check if it's a 
DefinedRowtimeAttributes/DefinedProctimeAttribute instance. If so, rewrite the 
TableSchema to patch the time indicator(as it is in 
ConnectorCatalogTable#calculateSourceSchema)
   - avoid erasing time indicator in CatalogSourceTable if the TableSource is a 
DefinedRowtimeAttributes/DefinedProctimeAttribute instance
   
   ## Verifying this change
   
   This change added tests.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** 
/ don't know)
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (**yes** / no)
     - If yes, how is the feature documented? (not applicable / docs / 
**JavaDocs** / not documented)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to