curcur commented on a change in pull request #12205:
URL: https://github.com/apache/flink/pull/12205#discussion_r427066016
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/channel/ChannelStateWriteRequestExecutorImpl.java
##########
@@ -79,7 +84,7 @@ private void loop() throws Exception {
dispatcher.dispatch(deque.take());
} catch (InterruptedException e) {
if (!wasClosed) {
- LOG.debug("interrupted while waiting
for a request (continue waiting)", e);
+ LOG.debug(taskName + "interrupted while
waiting for a request (continue waiting)", e);
Review comment:
add a white space
"interrupted... => " interrupted...
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/channel/ChannelStateWriterImpl.java
##########
@@ -104,48 +111,57 @@ public void start(long checkpointId, CheckpointOptions
checkpointOptions) {
@Override
public void addInputData(long checkpointId, InputChannelInfo info, int
startSeqNum, Buffer... data) {
- LOG.debug("add input data, checkpoint id: {}, channel: {},
startSeqNum: {}, num buffers: {}",
- checkpointId, info, startSeqNum, data == null ? 0 :
data.length);
+ LOG.debug("{} add input data, checkpoint id: {}, channel: {},
startSeqNum: {}, num buffers: {}",
Review comment:
Should the first parameter be in a separate line?
nit: add -> adds, similarly in other places. It reads a bit strange
otherwise. But I do not think it is a big problem.
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/channel/ChannelStateWriterImpl.java
##########
@@ -104,48 +111,57 @@ public void start(long checkpointId, CheckpointOptions
checkpointOptions) {
@Override
public void addInputData(long checkpointId, InputChannelInfo info, int
startSeqNum, Buffer... data) {
- LOG.debug("add input data, checkpoint id: {}, channel: {},
startSeqNum: {}, num buffers: {}",
- checkpointId, info, startSeqNum, data == null ? 0 :
data.length);
+ LOG.debug("{} add input data, checkpoint id: {}, channel: {},
startSeqNum: {}, num buffers: {}",
+ taskName,
+ checkpointId,
+ info,
+ startSeqNum,
+ data == null ? 0 : data.length);
enqueue(write(checkpointId, info, checkBufferType(data)),
false);
}
@Override
public void addOutputData(long checkpointId, ResultSubpartitionInfo
info, int startSeqNum, Buffer... data) {
- LOG.debug("add output data, checkpoint id: {}, channel: {},
startSeqNum: {}, num buffers: {}",
- checkpointId, info, startSeqNum, data == null ? 0 :
data.length);
+ LOG.debug("{} add output data, checkpoint id: {}, channel: {},
startSeqNum: {}, num buffers: {}",
Review comment:
a separate line?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
