Myasuka commented on a change in pull request #8693:
URL: https://github.com/apache/flink/pull/8693#discussion_r427189273
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/SubtaskCheckpointCoordinatorImpl.java
##########
@@ -126,6 +162,15 @@ public ChannelStateWriter getChannelStateWriter() {
return channelStateWriter;
}
+ @VisibleForTesting
+ int getAbortedCheckpointSize() {
+ return abortedCheckpointIds.size();
+ }
+
+ private boolean checkpointAlreadyAborted(long checkpointId) {
Review comment:
I think `getAndClearAbortedStatus` did not give explicit description of
the result when checking the notified checkpoint-id. I think
`isCheckpointAlreadyAborted` might be better than original name.
Moreover, I think we don't need to explain that we will clear the aborted
checkpoint-id if found which is too technically.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
