rkhachatryan opened a new pull request #12258:
URL: https://github.com/apache/flink/pull/12258


   ## What is the purpose of the change
   
   See FLINK-17820 for full problem description. In short, Flink ignores 
`state.backend.fs.memory-threshold` and always creates a file per subtask per 
checkpoint.
   
   This PR wraps `OutputStream` in `ChannelStateWriter` into a non-flushing 
one; so that data can be flushed from `DataOutputStream`, but not to disk.
   This solution was chosen:
   - over changing the original stream because of lower risk
   - over not flushing in `ChannelStateWriter` because that could lead to data 
loss in `DataOutputStream`
   
   ## Verifying this change
   
   Added `ChannelStateCheckpointWriterTest.testSmallFilesNotWritten`.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: yes
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not applicabl
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to