zhijiangW commented on a change in pull request #12261:
URL: https://github.com/apache/flink/pull/12261#discussion_r428139107



##########
File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
##########
@@ -181,6 +181,14 @@ void retriggerSubpartitionRequest(int subpartitionIndex) 
throws IOException {
                        moreAvailable = !receivedBuffers.isEmpty();
                }
 
+               if (next == null) {

Review comment:
       I guess it can probably happen in practice. When the canceler thread 
already released the respective input channel, but the task thread might still 
call `getNextBuffer` in the case of released `receivedBuffers`, then it can get 
the `null` buffer.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to