tzulitai commented on a change in pull request #115:
URL: https://github.com/apache/flink-statefun/pull/115#discussion_r428476280



##########
File path: statefun-e2e-tests/pom.xml
##########
@@ -63,11 +63,26 @@ under the License.
                         <version>1.6.0</version>
                         <executions>
                             <execution>
+                                <id>build-statefun-base-image</id>
+                                <goals>
+                                    <goal>exec</goal>
+                                </goals>
+                                <inherited>false</inherited>
                                 <phase>pre-integration-test</phase>
+                                <configuration>
+                                    
<executable>${user.dir}/tools/docker/build-stateful-functions.sh</executable>

Review comment:
       You're right, `user.dir` is not necessarily correct, depending on where 
the command was executed. I've changed this to a new `root.dir` property that 
captures the parent root dir of the project.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to