[ 
https://issues.apache.org/jira/browse/FLINK-14527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17115050#comment-17115050
 ] 

Jark Wu commented on FLINK-14527:
---------------------------------

Yes. I had a discussion with [~f.pompermaier] and [~Leonard Xu]. I looked into 
https://github.com/confluentinc/kafka-connect-jdbc. 
Kafka uses https://github.com/vorburger/MariaDB4j to test MySQL, uses 
https://github.com/zonkyio/embedded-postgres to test Postgres,
and for other databases they just unit test the dialect implementations. 


> Add integeration tests for PostgreSQL and MySQL dialects in flink jdbc module
> -----------------------------------------------------------------------------
>
>                 Key: FLINK-14527
>                 URL: https://issues.apache.org/jira/browse/FLINK-14527
>             Project: Flink
>          Issue Type: Improvement
>          Components: Connectors / JDBC
>            Reporter: Jark Wu
>            Priority: Major
>
> Currently, we already supported PostgreSQL and MySQL and Derby dialects in 
> flink-jdbc as sink and source. However, we only have integeration tests for 
> Derby. 
> We should add integeration tests for PostgreSQL and MySQL dialects too. Maybe 
> we can use JUnit {{Parameterized}} feature to avoid duplicated testing code.  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to