wuchong commented on a change in pull request #12260:
URL: https://github.com/apache/flink/pull/12260#discussion_r429716465
##########
File path:
flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/catalog/CatalogCalciteSchema.java
##########
@@ -42,10 +43,16 @@
private final CatalogManager catalogManager;
// Flag that tells if the current planner should work in a batch or
streaming mode.
private final boolean isStreamingMode;
+ private final SqlExprToRexConverterFactory converterFactory;
Review comment:
Could you add a short comment for this field to explain why we need
this? The same to `CatalogManagerCalciteSchema`, `CatalogSchemaTable`,
`DatabaseCalciteSchema`. For example:
```
The SQL expression converter factory is used to derive correct result type
of computed column, because the date type of computed column from catalog table
is not trusted.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
