fpompermaier commented on a change in pull request #11900:
URL: https://github.com/apache/flink/pull/11900#discussion_r429790764
##########
File path:
flink-connectors/flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/catalog/PostgresCatalogTestBase.java
##########
@@ -289,4 +292,29 @@ public static TestTable getArrayTable() {
));
}
+ public static TestTable getSerialTable() {
+ return new TestTable(
+ TableSchema.builder()
+ .field("f0", DataTypes.SMALLINT())
+ .field("f1", DataTypes.INT())
+ .field("f2", DataTypes.SMALLINT())
+ .field("f3", DataTypes.INT())
+ .field("f4", DataTypes.BIGINT())
+ .field("f5", DataTypes.BIGINT())
+ .build(),
+ "f0 smallserial, " +
+ "f1 serial, " +
+ "f2 serial2, " +
+ "f3 serial4, " +
+ "f4 serial8, " +
+ "f5 bigserial",
+ "0," +
+ "1," +
+ "2," +
+ "3," +
+ "4," +
+ "5"
Review comment:
Just one note..now I rebase the PR and addressed your comments..however
I also had to set notNull() on the fields because serial fields are marked as
not null by PG. Let me know if you think I should handle this situation in a
different way
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
