zentol commented on a change in pull request #12264:
URL: https://github.com/apache/flink/pull/12264#discussion_r429894695



##########
File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerServices.java
##########
@@ -265,10 +265,15 @@ public static TaskManagerServices fromConfiguration(
                // start the I/O manager, it will create some temp directories.
                final IOManager ioManager = new 
IOManagerAsync(taskManagerServicesConfiguration.getTmpDirPaths());
 
+               final ExecutorService ioExecutor = Executors.newFixedThreadPool(

Review comment:
       Technically yes, but I wouldn't know how many threads the executor 
should have. It is also easier to judge how many you'd need if the task and TM 
operations are separated.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to