rmetzger commented on a change in pull request #12268:
URL: https://github.com/apache/flink/pull/12268#discussion_r429917886
##########
File path: tools/ci/maven-utils.sh
##########
@@ -73,7 +73,7 @@ function collect_coredumps {
echo "Searching for .dump, .dumpstream and related files in
'$SEARCHDIR'"
for file in `find $SEARCHDIR -type f -regextype posix-extended -iregex
'.*\.hprof|.*\.dump|.*\.dumpstream|.*hs.*\.log|.*/core(.[0-9]+)?$'`; do
echo "Moving '$file' to target directory ('$TARGET_DIR')"
- mv $file $TARGET_DIR/
+ mv $file $TARGET_DIR/$(echo $file | tr "/" "-")
Review comment:
The problem I'm solving here is the following: Before this change, the
YARN test profile has the following output:
```
Moving
'/__w/2/s/flink-python/target/surefire-reports/2020-05-25T09-59-37_808.dumpstream'
to target directory ('/__w/2/s/tools/artifacts')
Moving
'/__w/2/s/flink-filesystems/flink-azure-fs-hadoop/target/surefire-reports/2020-05-25T09-59-37_808.dumpstream'
to target directory ('/__w/2/s/tools/artifacts')
Moving
'/__w/2/s/flink-examples/flink-examples-streaming/target/surefire-reports/2020-05-25T09-59-37_808.dumpstream'
to target directory ('/__w/2/s/tools/artifacts')
```
Since all the files have the same name, we will only provide the last file
to the user, not all of them.
With this change, we are effectively renaming the file to contain the path,
to make the filenames unique.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
