tillrohrmann commented on a change in pull request #12264:
URL: https://github.com/apache/flink/pull/12264#discussion_r431090914
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerRunner.java
##########
@@ -366,11 +367,15 @@ public static TaskExecutor startTaskManager(
resourceID,
taskManagerServicesConfiguration.getSystemResourceMetricsProbingInterval());
+ final ExecutorService ioExecutor =
Executors.newCachedThreadPool(
+ taskManagerServicesConfiguration.getNumIoThreads(),
+ new ExecutorThreadFactory("flink-taskexecutor-io"));
Review comment:
Jup. It is also a bit odd that
`TaskExecutorLocalStateStoresManagerTest.testCreationFromConfig` needs to
create a `TaskManagerServices` instance in order to test the
`TaskExecutorLocalStateStoresManager`. I think one could test the same if one
factored the creation of the `TaskExecutorLocalStateStoresManager` out into a
separate method which is called by `TaskManagerServices.fromConfiguration()`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
