[ 
https://issues.apache.org/jira/browse/FLINK-15507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17118924#comment-17118924
 ] 

Yu Li commented on FLINK-15507:
-------------------------------

After double checking the PR I found it actually enables local recovery for all 
state backends (and for RocksDB no matter whether the checkpoint is incremental 
or not) since currently there's only one uniform `state.backend.local-recovery` 
configuration in `CheckpointingOptions`, thus different implementation from the 
title and description of this JIRA.

I have some concerns about the cases with small local disk space and large 
state, especially when using RocksDB state backend with default checkpointing 
settings which means *full* checkpoint. So I'd like to confirm what we're 
proposing here: only enable local recovery for RocksDB backend with incremental 
checkpoint, or enable local recovery for all backends regardless of checkpoint 
option (full/incremental)?

I will hold the merging of the PR and wait for more feedbacks here. Thanks.

> Activate local recovery for RocksDB backends by default
> -------------------------------------------------------
>
>                 Key: FLINK-15507
>                 URL: https://issues.apache.org/jira/browse/FLINK-15507
>             Project: Flink
>          Issue Type: Improvement
>          Components: Runtime / State Backends
>            Reporter: Stephan Ewen
>            Assignee: Zakelly Lan
>            Priority: Blocker
>              Labels: pull-request-available
>             Fix For: 1.11.0
>
>
> For the RocksDB state backend, local recovery has no overhead when 
> incremental checkpoints are used. 
> It should be activated by default, because it greatly helps with recovery.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to