zhijiangW edited a comment on pull request #12374: URL: https://github.com/apache/flink/pull/12374#issuecomment-635723903
Thanks for review @pnowojski and @Jiayi-Liao ! I addressed the method rename issue, will merge after azure green. > supper nitty nit: I think it is touching the performance sensitive code (per buffer path) :) I'm pretty sure it doesn't affect performance, but it's touching them. **The runtime per-record code paths (performance sensitive): (yes / no / don't know)**, maybe we should adjust the template as `per-record` or `per-buffer`. :) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
