Jiayi-Liao commented on a change in pull request #11176:
URL: https://github.com/apache/flink/pull/11176#discussion_r433672113
##########
File path:
flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterDescriptor.java
##########
@@ -566,6 +562,22 @@ private ClusterSpecification validateClusterResources(
}
+ private void logIfComponentMemNotIntegerMultipleOfYarnMinAllocation(
+ String componentName,
+ int componentMemoryMB,
+ int yarnMinAllocationMB) {
+ int normalizedMemMB = (componentMemoryMB + (yarnMinAllocationMB
- 1)) / yarnMinAllocationMB * yarnMinAllocationMB;
Review comment:
@wangyang0918
Actually I'm here because I met the problem in our environment. I'm not an
expert on YARN but I think we should not rely on the yarn's limitations here.
Besides, if our assumption is that `yarnMinAllocationMB` should always be
greater than 0, why do we set the default value as 0, which is obviously a
wrong value and certainly crashes the job.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
