nielsbasjes commented on a change in pull request #11245:
URL: https://github.com/apache/flink/pull/11245#discussion_r433786745



##########
File path: docs/ops/deployment/kubernetes.md
##########
@@ -262,7 +262,7 @@ spec:
     spec:
       containers:
       - name: jobmanager
-        image: flink:{% if site.is_stable 
%}{{site.version}}-scala{{site.scala_version_suffix}}{% else %}latest{% endif %}
+        image: flink:{% if site.is_stable 
%}{{site.version}}-scala{{site.scala_version_suffix}}{% else %}latest # The 
'latest' tag contains the latest released version of Flink for a specific Scala 
version which will mismatch with your application over time.{% endif %}

Review comment:
       In my experience: Yes, the versions will mismatch at some point. 
   Also with a Scala mismatch the problem is big, yet with a Flink version 
mismatch I suspect more subtle problems to occur.
   
   Also I consider the choice of having Scala 2.12 the version used for 
"latest" a choice for today which may change (As I mentioned in the mailing 
list I am actually against having a "latest" for something like Flink).
   
   Note that this comment is ONLY shown when the documentation is generated for 
a non-stable "SNAPSHOT" build of the documentation. So the normal documentation 
should not show this.
   I duplicated it in all of those places because these are Kubernetes config 
files I expect to be used by operations people who will have limited knowledge 
of the application at hand.
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to