aljoscha commented on a change in pull request #12412: URL: https://github.com/apache/flink/pull/12412#discussion_r433930267
########## File path: flink-core/src/test/java/org/apache/flink/api/common/eventtime/AscendingTimestampsWatermarksTest.java ########## @@ -30,7 +30,10 @@ @Test public void testWatermarkBeforeRecords() { final TestingWatermarkOutput output = new TestingWatermarkOutput(); - final AscendingTimestampsWatermarks<Object> watermarks = new AscendingTimestampsWatermarks<>(); Review comment: You're right, I did change that to see if the builders work because there were no tests for that before, I did add tests in `WatermarkStrategyTest` already so I will undo these changes. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org