rmetzger commented on a change in pull request #12447:
URL: https://github.com/apache/flink/pull/12447#discussion_r435054927
##########
File path: tools/ci/compile.sh
##########
@@ -54,10 +54,22 @@ if [ $EXIT_CODE != 0 ]; then
exit $EXIT_CODE
fi
-echo "============ Checking Scaladocs ============"
+echo "============ Checking Javadocs and Scaladocs ============"
+
+# use the same invocation as on buildbot
(https://svn.apache.org/repos/infra/infrastructure/buildbot/aegis/buildmaster/master1/projects/flink.conf)
+run_mvn javadoc:aggregate -Paggregate-scaladoc
-DadditionalJOption='-Xdoclint:none' \
Review comment:
For the scala docs, I'm hiding all the warnings / errors and only show
them if the build fails. I'm always showing the maven output.
For the Javadocs, I don't know if the errors are send to stderr.
I have the feeling that it is not worth my time producing a javadoc error to
understand how the javadocs are printed (stderr vs stdout). I would rather
prefer to spend my time testing the new 1.11 features.
In my opinion, it is okay to have 25000 lines of logs for a regular Flink
compile.
If the compile stage passes, you usually don't check its output.
if it fails, you will see the error at the bottom of the file + a lot of
helpful debug information above (which you would see anyways).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
