zhuzhurk commented on a change in pull request #12278:
URL: https://github.com/apache/flink/pull/12278#discussion_r436533148



##########
File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/SlotPoolImpl.java
##########
@@ -648,26 +648,8 @@ boolean offerSlot(
                        slotOffer.getResourceProfile(),
                        taskManagerGateway);
 
-               // check whether we have request waiting for this slot
-               PendingRequest pendingRequest = 
pendingRequests.removeKeyB(allocationID);

Review comment:
       Yes still need the remapping to allow fail-fast on 
`UnfulfillableSlotRequestException`.
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to