[
https://issues.apache.org/jira/browse/FLINK-3296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15124777#comment-15124777
]
ASF GitHub Bot commented on FLINK-3296:
---------------------------------------
Github user mbalassi commented on the pull request:
https://github.com/apache/flink/pull/1563#issuecomment-177088061
With the `RollingHDFSSink` this functionality is not needed any more and as
you suggested apparently was a misleading implmentation anyway. I like your not
to the docs. :+1:
Could you add `[api-breaking]` to the commit msg though please, when
merging?
> DataStream.write*() methods are not flushing properly
> -----------------------------------------------------
>
> Key: FLINK-3296
> URL: https://issues.apache.org/jira/browse/FLINK-3296
> Project: Flink
> Issue Type: Bug
> Components: Streaming Connectors
> Reporter: Robert Metzger
> Assignee: Robert Metzger
> Priority: Critical
>
> The DataStream.write() methods rely on the {{FileSinkFunctionByMillis}}
> class, which has a logic for flushing records, even though the underlying
> stream is never flushed. This is misleading for users as files are not
> written as they would expect it.
> The code was initial written with FileOutputFormats in mind, but the types
> were not set correctly. This PR opened the write() method to any output
> format: https://github.com/apache/flink/pull/706/files
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
