carp84 edited a comment on pull request #12514: URL: https://github.com/apache/flink/pull/12514#issuecomment-643880827
The main reason of making `ReadOptions` configurable through `RocksDBOptionsFactory` is to provide a convenient way to revert the `setTotalOrderSeek(true)` setting and prevent possible (unexpected) performance regression under real-world workload, although we have tried our best to safeguard it through micro-benchmark. OTOH, we actually find there're more setters in `ReadOptions` and `WriteOptions` than what we set as default: * ReadOptions: `setFillCache`, `setManaged`, `setPinData`, `setReadTier`, **`setTotalOrderSeek`**, `setVerifyChecksums`, etc. * WriteOptions: **`setDisableWAL`**, `setIgnoreMissingColumnFamilies`, `setNoSlowdown`, `setSync`, etc. However, I could also understand if we choose to hide these detailed options from our users and believe our micro-benchmark result that `setTotalOrderSeek(true)` won't cause any regression in Flink use case. So just to clarify my thoughts and look forward to your opinion @StephanEwen. Thanks. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
