wuchong commented on a change in pull request #12657:
URL: https://github.com/apache/flink/pull/12657#discussion_r440643763
##########
File path:
flink-end-to-end-tests/flink-end-to-end-tests-common/src/main/java/org/apache/flink/tests/util/AutoClosableProcess.java
##########
@@ -167,6 +186,18 @@ private static void processStream(final InputStream
stream, final Consumer<Strin
).start();
}
+ private static void processOutputStream(final OutputStream stream,
final List<String> inputs) {
+ new Thread(() -> {
Review comment:
This keeps align with `processInputStream`, we shouldn't block here,
because the blocking/non-blocking is determined by user
`AutoClosableProcessBuilder#runNonBlocking` or
`AutoClosableProcessBuilder#runBlocking()`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
