wuchong commented on a change in pull request #11512:
URL: https://github.com/apache/flink/pull/11512#discussion_r441942913
##########
File path:
flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/AggregateITCase.scala
##########
@@ -1334,4 +1334,32 @@ class AggregateITCase(
val expected = Seq("3,29.39,[email protected]")
assertEquals(expected.sorted, sink.getRetractResults.sorted)
}
+
+ @Test
+ def testSplitAggsHandler(): Unit = {
Review comment:
Could you rename to `testAggregationCodeSplit` ? We have a
`SplitAggregateITCase` test which may be confuse users the naming.
##########
File path:
flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/AggregateITCase.scala
##########
@@ -1334,4 +1334,32 @@ class AggregateITCase(
val expected = Seq("3,29.39,[email protected]")
assertEquals(expected.sorted, sink.getRetractResults.sorted)
}
+
+ @Test
+ def testSplitAggsHandler(): Unit = {
+
+ val t = env.fromCollection(TestData.smallTupleData3)
+ .toTable(tEnv, 'a, 'b, 'c)
+ tEnv.createTemporaryView("MyTable", t)
+
+ tEnv.getConfig.setMaxGeneratedCodeLength(1)
+
+ val columnNumber = 100
Review comment:
I would like to update this a bit. I tried to revert the changes and
this test is still passed. That means this test can't reproduce the 64K
problem. I changed to number up to `500` and reproduced this problem. Besides,
I would like to remove `tEnv.getConfig.setMaxGeneratedCodeLength(1)` to make
sure it works well with out-of-box configuration.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
