rkhachatryan opened a new pull request #12714:
URL: https://github.com/apache/flink/pull/12714
## What is the purpose of the change
Wait for the `LegacySourceFunctionThread` to finish when cancelling the task.
This prevents premature freeing of resources, particularly LibraryCache (see
FLINK-15467 discussion).
Implemented by adding `Task. invokableCancelFuture` instead of just joining
the source thread in `cancelTask`. This is because `cancelTask` can be called
from TaskCanceller, while resources are freed by `Task.executingThread` or upon
its death.
## Brief change log
There are three commits that should be squashed after reviewing:
- Return future from `StreamTask.cancelTask` and finishTask - only change
of signatures except for `SourceStreamTask`
- Return completion future from `AbstractInvokable` cancel - only change of
signatures except for `StreamTask`
- Wait in `Task.cancelInvokable` for completion
## Verifying this change
- Added unit test: `TaskTest.testTaskTerminatesOnlyAfterInvokable`
- Manually tested on cluster
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
