godfreyhe commented on a change in pull request #12728:
URL: https://github.com/apache/flink/pull/12728#discussion_r444047393
##########
File path:
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/TableEnvironmentImpl.java
##########
@@ -705,7 +705,7 @@ public TableResult executeInternal(QueryOperation
operation) {
.tableSchema(operation.getTableSchema())
.data(resultProvider.getResultIterator())
.setPrintStyle(TableResultImpl.PrintStyle.tableau(
-
PrintUtils.MAX_COLUMN_WIDTH, PrintUtils.NULL_COLUMN, isStreamingMode))
+
PrintUtils.MAX_COLUMN_WIDTH, PrintUtils.NULL_COLUMN, true, isStreamingMode))
Review comment:
The batch select result may be very large to be stored in local java
heap memory, so I prefer to derive column width based on type for both mode
select result.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
