[ 
https://issues.apache.org/jira/browse/FLINK-3336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15132920#comment-15132920
 ] 

ASF GitHub Bot commented on FLINK-3336:
---------------------------------------

Github user uce commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1589#discussion_r51930125
  
    --- Diff: 
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/partitioner/SemiRebalancePartitionerTest.java
 ---
    @@ -0,0 +1,202 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.streaming.runtime.partitioner;
    +
    +import org.apache.flink.api.common.JobID;
    +import org.apache.flink.api.common.functions.FlatMapFunction;
    +import org.apache.flink.api.java.tuple.Tuple;
    +import org.apache.flink.api.java.tuple.Tuple2;
    +import org.apache.flink.configuration.Configuration;
    +import org.apache.flink.runtime.JobException;
    +import org.apache.flink.runtime.akka.AkkaUtils;
    +import org.apache.flink.runtime.blob.BlobKey;
    +import org.apache.flink.runtime.executiongraph.ExecutionEdge;
    +import org.apache.flink.runtime.executiongraph.ExecutionGraph;
    +import org.apache.flink.runtime.executiongraph.ExecutionJobVertex;
    +import org.apache.flink.runtime.executiongraph.ExecutionVertex;
    +import org.apache.flink.runtime.jobgraph.JobGraph;
    +import org.apache.flink.runtime.jobgraph.JobVertex;
    +import org.apache.flink.runtime.plugable.SerializationDelegate;
    +import org.apache.flink.runtime.testingUtils.TestingUtils;
    +import org.apache.flink.streaming.api.datastream.DataStream;
    +import 
org.apache.flink.streaming.api.environment.StreamExecutionEnvironment;
    +import 
org.apache.flink.streaming.api.functions.source.ParallelSourceFunction;
    +import org.apache.flink.streaming.runtime.operators.StreamTaskTimerTest;
    +import org.apache.flink.streaming.runtime.streamrecord.StreamRecord;
    +import org.apache.flink.util.Collector;
    +import org.junit.Before;
    +import org.junit.Test;
    +
    +import java.net.URL;
    +import java.util.ArrayList;
    +import java.util.HashMap;
    +import java.util.HashSet;
    +import java.util.List;
    +import java.util.Map;
    +import java.util.Set;
    +
    +import static org.junit.Assert.*;
    +
    +public class SemiRebalancePartitionerTest {
    +   
    +   private SemiRebalancePartitioner<Tuple> distributePartitioner;
    +   private StreamRecord<Tuple> streamRecord = new 
StreamRecord<Tuple>(null);
    +   private SerializationDelegate<StreamRecord<Tuple>> sd = new 
SerializationDelegate<StreamRecord<Tuple>>(
    +                   null);
    +   
    +   @Before
    +   public void setPartitioner() {
    +           distributePartitioner = new SemiRebalancePartitioner<Tuple>();
    --- End diff --
    
    Nice way to write the test. Personally, never did it like this. :)


> Add Semi-Rebalance Data Shipping for DataStream
> -----------------------------------------------
>
>                 Key: FLINK-3336
>                 URL: https://issues.apache.org/jira/browse/FLINK-3336
>             Project: Flink
>          Issue Type: Improvement
>          Components: Streaming
>            Reporter: Aljoscha Krettek
>            Assignee: Aljoscha Krettek
>             Fix For: 1.0.0
>
>
> This feature has recently been requested on the ML: 
> http://apache-flink-user-mailing-list-archive.2336050.n4.nabble.com/Distribution-of-sinks-among-the-nodes-td4640.html
> The new data shipping pattern would allow to rebalance data only to a subset 
> of downstream operations.
> The subset of downstream operations to which the upstream operation would send
> elements depends on the degree of parallelism of both the upstream and 
> downstream operation.
> For example, if the upstream operation has parallelism 2 and the downstream 
> operation
> has parallelism 4, then one upstream operation would distribute elements to 
> two
> downstream operations while the other upstream operation would distribute to 
> the other
> two downstream operations. If, on the other hand, the downstream operation 
> had parallelism
> 2 while the upstream operation has parallelism 4 then two upstream operations 
> would
> distribute to one downstream operation while the other two upstream 
> operations would
> distribute to the other downstream operations.
> In cases where the different parallelisms are not multiples of each other one 
> or several
> downstream operations would have a differing number of inputs from upstream 
> operations.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to