[
https://issues.apache.org/jira/browse/FLINK-2213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15135751#comment-15135751
]
ASF GitHub Bot commented on FLINK-2213:
---------------------------------------
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1588#issuecomment-180753150
I didn't test this myself, but this diff could be sufficient for testing
your change:
```diff
diff --git
a/flink-yarn-tests/src/main/java/org/apache/flink/yarn/YARNSessionFIFOITCase.java
b/flink-yarn-tests/src/main/java/org/apache/flink/yarn/YARNSessionFIFOITCase.java
index 8c9a9c7..999b5be 100644
---
a/flink-yarn-tests/src/main/java/org/apache/flink/yarn/YARNSessionFIFOITCase.java
+++
b/flink-yarn-tests/src/main/java/org/apache/flink/yarn/YARNSessionFIFOITCase.java
@@ -180,6 +180,7 @@ public class YARNSessionFIFOITCase extends YarnTestBase
{
"-n", "1",
"-jm", "768",
"-tm", "1024",
+ "-s", "3", // set the slots 3 to check if
the vCores are set properly!
"-nm", "customName",
"-Dfancy-configuration-value=veryFancy",
"-Dyarn.maximum-failed-containers=3"},
@@ -268,6 +269,7 @@ public class YARNSessionFIFOITCase extends YarnTestBase
{
String command = Joiner.on("
").join(entry.getValue().getLaunchContext().getCommands());
if(command.contains(YarnTaskManagerRunner.class.getSimpleName())) {
taskManagerContainer =
entry.getKey();
+
Assert.assertEquals(3,entry.getValue().getResource().getVirtualCores());
nodeManager = nm;
nmIdent = new
NMTokenIdentifier(taskManagerContainer.getApplicationAttemptId(), null, "",0);
// allow myself to do stuff with
the container
```
> Configure number of vcores
> --------------------------
>
> Key: FLINK-2213
> URL: https://issues.apache.org/jira/browse/FLINK-2213
> Project: Flink
> Issue Type: Improvement
> Components: YARN Client
> Affects Versions: 0.10.0
> Reporter: Ufuk Celebi
> Assignee: Kostas
> Fix For: 1.0.0
>
>
> Currently, the number of vcores per YARN container is set to 1.
> It is desirable to allow configuring this value. As a simple heuristic it
> makes sense to at least set it to the number of slots per container.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
