Github user mxm commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1591#discussion_r52102060
  
    --- Diff: 
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/api/FlinkTopology.java
 ---
    @@ -229,9 +229,24 @@ private void translateTopology() {
                boolean makeProgress = true;
                while (bolts.size() > 0) {
                        if (!makeProgress) {
    -                           throw new RuntimeException(
    -                                           "Unable to build Topology. 
Could not connect the following bolts: "
    -                                                           + 
bolts.keySet());
    +                           StringBuilder strBld = new StringBuilder();
    +                           strBld.append("Unable to build Topology. Could 
not connect the following bolts:");
    +                           for (String boltId : bolts.keySet()) {
    +                                   strBld.append("\n  ");
    +                                   strBld.append(boltId);
    +                                   strBld.append(": missing input streams 
[");
    +                                   for (Entry<GlobalStreamId, Grouping> 
streams : unprocessdInputsPerBolt
    +                                                   .get(boltId)) {
    +                                           strBld.append("'");
    +                                           
strBld.append(streams.getKey().get_streamId());
    +                                           strBld.append("' from '");
    +                                           
strBld.append(streams.getKey().get_componentId());
    +                                           strBld.append("'; ");
    +                                   }
    +                                   strBld.append("]");
    --- End diff --
    
    Nice. That's helpful for debugging.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to