[ 
https://issues.apache.org/jira/browse/FLINK-2721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15135762#comment-15135762
 ] 

ASF GitHub Bot commented on FLINK-2721:
---------------------------------------

Github user mxm commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1591#discussion_r52102060
  
    --- Diff: 
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/api/FlinkTopology.java
 ---
    @@ -229,9 +229,24 @@ private void translateTopology() {
                boolean makeProgress = true;
                while (bolts.size() > 0) {
                        if (!makeProgress) {
    -                           throw new RuntimeException(
    -                                           "Unable to build Topology. 
Could not connect the following bolts: "
    -                                                           + 
bolts.keySet());
    +                           StringBuilder strBld = new StringBuilder();
    +                           strBld.append("Unable to build Topology. Could 
not connect the following bolts:");
    +                           for (String boltId : bolts.keySet()) {
    +                                   strBld.append("\n  ");
    +                                   strBld.append(boltId);
    +                                   strBld.append(": missing input streams 
[");
    +                                   for (Entry<GlobalStreamId, Grouping> 
streams : unprocessdInputsPerBolt
    +                                                   .get(boltId)) {
    +                                           strBld.append("'");
    +                                           
strBld.append(streams.getKey().get_streamId());
    +                                           strBld.append("' from '");
    +                                           
strBld.append(streams.getKey().get_componentId());
    +                                           strBld.append("'; ");
    +                                   }
    +                                   strBld.append("]");
    --- End diff --
    
    Nice. That's helpful for debugging.


> Add Tuple meta information
> --------------------------
>
>                 Key: FLINK-2721
>                 URL: https://issues.apache.org/jira/browse/FLINK-2721
>             Project: Flink
>          Issue Type: New Feature
>          Components: Storm Compatibility
>            Reporter: Matthias J. Sax
>            Assignee: Matthias J. Sax
>            Priority: Minor
>
> In {{Bolt.execute(Tuple input)}} the given input tuple contains meta 
> information about its origin (like source component name, stream id, source 
> task ID).
> This meta information in currently not provided by Flink and the 
> corresponding methods throw an {{UnsupportedOperationException}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to