JingsongLi commented on a change in pull request #12856:
URL: https://github.com/apache/flink/pull/12856#discussion_r452128711
##########
File path:
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/util/HiveTableUtil.java
##########
@@ -453,22 +454,16 @@ public String visit(ValueLiteralExpression valueLiteral) {
if (value == null) {
return "null";
}
+ LogicalTypeRoot typeRoot =
dataType.getLogicalType().getTypeRoot();
+ if
(typeRoot.getFamilies().contains(LogicalTypeFamily.DATETIME)) {
+ // hive not support partition filter push down
with these types.
Review comment:
Minor: Add comments to explain, there are some bugs in below codes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
