[
https://issues.apache.org/jira/browse/FLINK-3353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15136027#comment-15136027
]
ASF GitHub Bot commented on FLINK-3353:
---------------------------------------
GitHub user stefanobaghino opened a pull request:
https://github.com/apache/flink/pull/1598
[FLINK-3353] CSV-related tests may fail depending on locale
As the results are hard-coded, it makes sense to explicitly pass the US
locale to render the results as strings. Should close
[FLINK-3353](https://issues.apache.org/jira/browse/FLINK-3353).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/radicalbit/flink 3353
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1598.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1598
----
commit ef91c907105638fe4d839dc891d3af33ba35e2a8
Author: Stefano Baghino <[email protected]>
Date: 2016-02-06T21:57:33Z
[FLINK-3353] CSV-related tests may fail depending on locale
----
> CSV-related tests may fail depending on locale
> ----------------------------------------------
>
> Key: FLINK-3353
> URL: https://issues.apache.org/jira/browse/FLINK-3353
> Project: Flink
> Issue Type: Bug
> Components: Tests
> Affects Versions: 1.0.0
> Reporter: Stefano Baghino
> Assignee: Stefano Baghino
> Priority: Trivial
> Fix For: 1.0.0
>
>
> As I've been running some tests, three suites
> ({{KMeansWithBroadcastSetITCase.java}},
> {{ScalaCsvReaderWithPOJOITCase.scala}} and {{CsvReaderITCase.java}}) kept
> failing locally because the expected results (string literals) were matched
> against an object rendered as a string using the {{String.format}} method, a
> method whose result depends on the default Locale; as my Locale (Italian)
> renders doubles with a comma instead of a dot as the decimal separator, the
> representation of doubles diverged from the expected one, thus making my
> tests fail, despite the results actually being correct.
> As the result is hard-coded, it makes sense to explicitly use the US locale
> to represent those object. I'll open a PR with my solution ASAP.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
