wuchong commented on a change in pull request #12868:
URL: https://github.com/apache/flink/pull/12868#discussion_r453400509
##########
File path:
flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/plan/batch/sql/TableScanTest.scala
##########
@@ -171,4 +171,38 @@ class TableScanTest extends TableTestBase {
.createTemporaryTable("t1")
util.verifyPlan(util.tableEnv.from("t1"))
}
+
+ @Test
+ def testCreateViewWithRowNumber(): Unit = {
Review comment:
Could you add this test to `RankTest`?
##########
File path:
flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/plan/batch/sql/TableScanTest.scala
##########
@@ -171,4 +171,38 @@ class TableScanTest extends TableTestBase {
.createTemporaryTable("t1")
util.verifyPlan(util.tableEnv.from("t1"))
}
+
+ @Test
+ def testCreateViewWithRowNumber(): Unit = {
+ util.addTable(
+ """
+ |CREATE TABLE test_source (
+ | name STRING,
+ | eat STRING,
+ | age BIGINT
+ |) WITH (
+ | 'connector' = 'values',
+ | 'bounded' = 'true'
Review comment:
Could you use `bounded = false` ? This can verify whether the Rank
operator is generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
